fix: break CI again 🥲 #1859
Merged
fix: break CI again 🥲 #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Codecov Report
@@ Coverage Diff @@
## develop #1859 +/- ##
===========================================
- Coverage 86.46% 86.16% -0.30%
===========================================
Files 589 589
Lines 95599 95647 +48
===========================================
- Hits 82660 82416 -244
- Misses 12939 13231 +292 |
paomian
pushed a commit
to paomian/greptimedb
that referenced
this pull request
Oct 19, 2023
* fix information schema case Signed-off-by: Ruihang Xia <waynestxia@gmail.com> * disable -Wunused_result lint Signed-off-by: Ruihang Xia <waynestxia@gmail.com> --------- Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA
What's changed and what's your intention?
-Wunused_resultsintroduced in chore: deny unused results #1825let _may lead to other errors like forgetting to.awaita future etcChecklist
Refer to a related PR or issue link (optional)